Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert t.Fatal to t.Error and return to follow vet recommendation #1312

Merged
merged 1 commit into from Apr 11, 2022

Conversation

aidan-kwon
Copy link
Member

@aidan-kwon aidan-kwon commented Apr 8, 2022

Proposed changes

make test fails with the following errors when the machine use golang v1.16 or higher.

blockchain/blockchain_test.go:1042:6: call to (*T).Fatalf from a non-test goroutine

From go1.16, Vet warns the use of t.Fatal in goroutines during the test.
And, the warning stops the further process of make test.
So, all t.Fatal in goroutines in test files are converted to t.Error and return as golang release note suggested.

Reference: Vet section in go1.16 Release note

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@kjhman21 kjhman21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aidan-kwon aidan-kwon merged commit cf66c38 into klaytn:dev Apr 11, 2022
@aidan-kwon aidan-kwon deleted the 220408-vetFatal branch April 11, 2022 04:06
aidan-kwon added a commit to aidan-kwon/klaytn that referenced this pull request Apr 19, 2022
Convert t.Fatal to t.Error and return to follow vet recommendation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants