tracers: refactor tracer api and avoid OOM while tracing #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomee1313
changed the title
yoomee1313
force-pushed
the
avoid-OOM-when-traceChain
branch
from
fccfb57
to
ab3222b
Compare
yoomee1313
requested review from
KimKyungup,
aidan-kwon,
ehnuje,
henry-will,
hyunsooda,
hqjang-pepper,
ethan-kr,
jeongkyun-oh,
nohkwak and
2dvorak
as code owners
9 tasks
yoomee1313
force-pushed
the
avoid-OOM-when-traceChain
branch
from
93cb466
to
397e334
Compare
added 2 commits
August 17, 2022 16:12
aidan-kwon
reviewed
Aug 17, 2022
aidan-kwon
reviewed
Aug 17, 2022
jeongkyun-oh
previously approved these changes
Aug 17, 2022
kjhman21
reviewed
Aug 17, 2022
| "github.com/klaytn/klaytn/rlp" | ||
| statedb2 "github.com/klaytn/klaytn/storage/statedb" |
There was a problem hiding this comment.
Do we need to change the name statedb2 here?
There was a problem hiding this comment.
It is changed from statedb package to database package here. So I think it is not necessary to use the name statedb2 here.
|
@jeongkyun-oh @aidan-kwon @kjhman21 Please take another look. It would be appreciate if you approve this PR. |
jeongkyun-oh
approved these changes
Aug 18, 2022
henry-will
approved these changes
Aug 18, 2022
|
I'll merge this. If you have other opinion, feel free to leave a comment here. |
aidan-kwon
pushed a commit
to aidan-kwon/klaytn
that referenced
this pull request
Aug 18, 2022
tracers: refactor tracer api and avoid OOM while tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
eth/tracers: move tracing APIs into eth/tracers ethereum/go-ethereum#22161
eth, les: fix tracer ethereum/go-ethereum#22473
eth: make traceChain avoid OOM on long-running tracing ethereum/go-ethereum#23736
Test result: test is done by tracing a block which contains 1000 txs(transferSignedTx, internalCallTx). CallTracer is used.
EN0(PR): It releases memory allocation immediately when tracing ends.
EN1(dev): It holds unnecessary memory allocation for a long time.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...