More accurate header size calculation

[hyunsooda]

Proposed changes

• Added size property to header RPC output.
• Fixed header size summation
• Fixed output path of go generate command

Types of changes

Please put an x in the boxes related to your change.

• Bugfix
• New feature or enhancement
• Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING GUIDELINES doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes ($ make test)
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in downstream modules

Related issues

• Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[blukat29]

@hyunsooda Let's clarify Size() function as it was already too long.

func (h *Header) Size() common.StorageSize {
        size := common.StorageSize(unsafe.Sizeof(*h))

        byteSize := len(h.Extra) + len(h.Governance) + len(h.Vote)
        size += common.StorageSize(byteSize)

        bigBits := h.BlockScore.BitLen() + h.Number.BitLen() + h.Time.BitLen()
        if h.BaseFee != nil {
                bigBits += h.BaseFee.BitLen()
        }
        size += common.StorageSize(bigBits / 8)
        return size
}

And add a test case

func TestHeaderSize(t *testing.T) {
        preMagmaSize := genHeader().Size()
        magmaSize := genMagmaHeader().Size()
        assert.NotEqual(t, preMagmaSize, magmaSize)
}

[hyunsooda]

@blukat29, Refactored. A unit test was added too, but I prefer not to include the unit test for it because its test seems semantically meaningless.

[blukat29]

@hyunsooda The TestHeaderSizeCalc at least tests the Size function with and without BaseFee. Just to make sure there's no coding error, nil pointer mistake, etc. It's no harm having a small unit test.

[hyunsooda]

@ian0371, I would like to hear your opinion on this. Please let me know if I should make further changes or consider this not feasible for now so I can close it.

[hyunsooda]

I discovered that certain tests were not accurately executed due to an incorrect hardcoded value (https://github.com/klaytn/klaytn/blob/dev/blockchain/types/block_test.go#L49). Fixed together in this PR.

[blukat29]

LGTM. @hyunsooda Can you check the CLA again? https://cla-assistant.io/klaytn/klaytn

[hyunsooda]

@blukat29, I'm sorry. Signed now.

@jaydenhur, The licence checker seems stuck. How it can be refreshed?