New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trie parallel hashing #1659
Trie parallel hashing #1659
Conversation
…perate-trie-commit-and-hash
…ie-parallel-hashing
before & after applying #1659 + #1656
|
…jang-pepper/klaytn into trie-parallel-hashing
collapsed.Children[i], cached.Children[i] = h.hash(child, false) | ||
} else { | ||
collapsed.Children[i] = nilValueNode | ||
} | ||
} | ||
} | ||
cached.Children[16] = n.Children[16] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ethereum PR, this line is removed, but not here. Any reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cached.Children[16] = n.Children[16]
you mean this line?
Yeah you are right, ethereum changed this line but I didn't, because changing logic has nothing to do with Children[16], So I didn't change this part
Replaced by #1840. |
Proposed changes
This is a follow-up PR of #1656, should be merged after #1656
unhashed >= 100
, fullNode hashing operation is parallelizedTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...