yaml configuration for booting the each nodes

[kjeom]

Proposed changes

• Migration from urfave/cli.v1 to urfave/cli/v2

  • See https://cli.urfave.org/migrate-v1-to-v2/ for full list of changes.
  • Changes to our codebase:
    • Specify flag aliases as Flag.Aliases []string
    • Specify flag envs as Flag.EnvVars []string
    • Flags are now pointers &cli.BoolFlag{ ... }
    • Commands are now pointers &cli.Command{ ... }
    • No ctx.GlobalString(). There is only ctx.String(). Same goes for each flag types.

• Flag positioning

  • Command - Flag - Args order is now important.

    kcn init --datadir mydata genesjs.json   # cmd-flag-args OK
    kcn --datadir mydata init genesis.json   # flag-cmd-args OK
    kcn init genesis.json --datadir mydata   # cmd-args-flag BAD

• Load flags from a YAML file

  • ken --conf config.yaml
  • The YAML file contains the (key, value) pairs where the key is a flag name or alias.

• Refactor

  • Move file cmd/utils/nodecmd/nodeflags.go to cmd/utils/nodeflags.go
  • Move function checkExclusive to utils.CheckExclusive

Types of changes

Please put an x in the boxes related to your change.

• Bugfix
• New feature or enhancement
• Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING GUIDELINES doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes ($ make test)
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)
• Any dependent changes have been merged and published in downstream modules

Related issues

• Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[blukat29]

LGTM except merge conflict

[blukat29]

@kjeom
There are some cases where GlobalIsSet is replaced with Bool.
Can we keep it IsSet in this PR, and refactor like below in another PR?

- if ctx.IsSet(..) {
-     cfg.Item = ctx.Bool(..)
- }
+ cfg.Item = ctx.Bool(..)

- cfg.Item = ctx.IsSet(..)
+ cfg.Item = ctx.Bool(..)

[kjeom]

@kjeom There are some cases where GlobalIsSet is replaced with Bool. Can we keep it IsSet in this PR, and refactor like below in another PR?

- if ctx.IsSet(..) {
-     cfg.Item = ctx.Bool(..)
- }
+ cfg.Item = ctx.Bool(..)

- cfg.Item = ctx.IsSet(..)
+ cfg.Item = ctx.Bool(..)

Sure and any issues?

[blukat29]

@kjeom Because it's difficult to review. If it's not changed I can just compare side-by-side.

[kjeom]

@kjeom Because it's difficult to review. If it's not changed I can just compare side-by-side.

Ok, but I have left a comment for a case.

[aidan-kwon]

UnsafeDebugDisableFlag, RPCGlobalEVMTimeoutFlag are missing from CommonRPCFlags

[aidan-kwon]

LGTM except for @blukat29's command and my minor comment. Let's handle this in another PR