Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trie node unit tests #1843

Merged
merged 7 commits into from
May 22, 2023
Merged

Add trie node unit tests #1843

merged 7 commits into from
May 22, 2023

Conversation

blukat29
Copy link
Contributor

Proposed changes

  • Add unit tests
    • storage/statedb/node_test.go tests decodeNode()
    • storage/statedb/hasher_test.go tests hasher.hash()
  • Minor syntax improvement
    • append(valueNode{}, val...) -> valueNode(val)
  • Silence print_trie_test.go

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 changed the title Add node_test.go for decodeNode Add trie node unit tests May 16, 2023
@blukat29 blukat29 self-assigned this May 16, 2023
jeongkyun-oh
jeongkyun-oh previously approved these changes May 19, 2023
Copy link
Contributor

@jeongkyun-oh jeongkyun-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for minors

@blukat29 blukat29 merged commit 398dcf2 into klaytn:dev May 22, 2023
11 checks passed
@blukat29 blukat29 deleted the test-statedb-node branch May 22, 2023 03:44
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants