Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce trie constructors with TrieOpts #1854

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented May 26, 2023

Proposed changes

  • Replace NewXxxForPrefetching(...) with NewXxx(..., &TrieOpts{Prefetching: true})
  • Later, the TrieOpts will contain the KIP-111 state pruning flags. The flags shall be injected from the command line -> cn.New -> blockchain -> ...TrieOpts... -> trie.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

  • Q. Why call it Opts not Config?
    • A. I want to reserve "Config" for the future. Just in case we ever use Database config.
    • geth is using trie.Config struct to pass cache-related options. (source)
  • To compare klaytn statedb and geth trie packages:
Type klaytn (after this PR) geth 1.11.5
Database NewDatabase
NewDatabaseWithNewCache
NewDatabaseWithExistingCache
struct Config{ Cache }
NewDatabase
NewDatabaseWithConfig
Trie struct TrieOpts{ Prefetching }
New
NewForPrefetching
New

@blukat29 blukat29 merged commit 35ad06b into klaytn:dev Jun 8, 2023
2 checks passed
@blukat29 blukat29 deleted the refactor-trie-opts branch June 8, 2023 02:38
@JayChoi1736 JayChoi1736 mentioned this pull request Jul 24, 2023
20 tasks
@aidan-kwon aidan-kwon mentioned this pull request Jul 30, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants