Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update circleci to use go 1.20.6 #1901

Merged
merged 3 commits into from Jul 26, 2023

Conversation

Sotatek-TinnNguyen
Copy link
Contributor

@Sotatek-TinnNguyen Sotatek-TinnNguyen commented Jul 26, 2023

Proposed changes

  • Upgrade CircleCi to use new image of build_base:1.2-go.1.20.6-solc0.8.13 and golang 1.20.6

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

aidan-kwon
aidan-kwon previously approved these changes Jul 26, 2023
Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@aidan-kwon
Copy link
Member

@yoomee1313 Please see the test failures

@yoomee1313 yoomee1313 requested a review from ian0371 as a code owner July 26, 2023 08:00
@yoomee1313 yoomee1313 added the need to merge Need to merge for the next time label Jul 26, 2023
@yoomee1313
Copy link
Contributor

@aidan-kwon The test was failed due to the error came out from vet. It is resolved now, so we can review/merge this PR. cc. @Sotatek-TinnNguyen

@yoomee1313 yoomee1313 merged commit f1fedce into klaytn:dev Jul 26, 2023
11 checks passed
@yoomee1313 yoomee1313 mentioned this pull request Jul 27, 2023
20 tasks
@Sotatek-TinnNguyen Sotatek-TinnNguyen deleted the circleci_go1.20 branch July 27, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need to merge Need to merge for the next time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants