Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live pruning is available in archive mode #1914

Merged
merged 4 commits into from Jul 31, 2023

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented Jul 31, 2023

Proposed changes

  • Enable live pruning in archive mode
    • Currently only worked in full mode. Now it also works in archive mode.
  • Address some leftover comments in KIP-111 Prune obsolete trie nodes #1871.
    • Add comments to DeletePruningEnabled() that it is for testing
    • Add missing it.Release() in ReadPruningMarks()
    • Refactor bc.IsLivePruningRequired()
    • When live pruning is disabled, do not start the goroutine in pruneTrieNodeLoop

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 requested a review from hyunsooda July 31, 2023 05:58
@blukat29 blukat29 mentioned this pull request Jul 31, 2023
9 tasks
@blukat29 blukat29 changed the title Live pruning minor fixes Enable live pruning in archive mode Jul 31, 2023
@blukat29
Copy link
Contributor Author

@jeongkyun-oh @ethan-kr This PR was supposed to be just minor fixes but incorporated your request to perform pruning in archive mode. PTAL.

@blukat29 blukat29 changed the title Enable live pruning in archive mode Live pruning is available in archive mode Jul 31, 2023
blockchain/blockchain.go Show resolved Hide resolved
@blukat29 blukat29 merged commit 9243fae into klaytn:dev Jul 31, 2023
11 checks passed
@blukat29 blukat29 deleted the 20230731-pruning-fix branch August 3, 2023 08:08
@aidan-kwon aidan-kwon mentioned this pull request Aug 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants