Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Nil-dereference of client API call fixed #1915

Merged
merged 2 commits into from Aug 8, 2023

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

This PR aims to address potential nil dereference issues and prevent crashes caused by invalid input. The changes made in this PR ensure that if a value is found to be nil, an appropriate error is returned instead of attempting to proceed with the nil value (crash).

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aidan-kwon aidan-kwon added the need to merge Need to merge for the next time label Aug 3, 2023
@aidan-kwon
Copy link
Member

@kjeom PTAL

@hyunsooda hyunsooda merged commit a606983 into klaytn:dev Aug 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need to merge Need to merge for the next time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants