Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence Error log when AddressBook code is not installed #1978

Merged
merged 1 commit into from Sep 27, 2023

Conversation

blukat29
Copy link
Contributor

Proposed changes

In the chains without AddressBook installed at genesis,

  • Until v1.10.2, only an INFO log is printed:
    INFO[09/25,05:53:52 Z] [44] The addressBook is not installed. Use empty stakingInfo
    
  • Starting from v1.11.0, ERROR logs are printed, clogging the log even at a high log level.
    ERROR[09/25,05:56:38 Z] [44] failed to update stakingInfo              staking block number=0 err="failed to call AddressBook contract. root err: no contract code at given address"
    ERROR[09/25,05:56:38 Z] [44] unable to fetch staking info              blockNum=3
    

This PR reverts to v1.10.2 behavior.

  • This PR does not affect Cypress and Baobab because AddressBook is installed there.
  • This PR does not affect service chains with RoundRobin or Sticky proposer policy
  • This PR affects service chains with WeightedRandom proposer policy in the log message perspective, but the proposer selection procedure should not change.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blukat29 blukat29 merged commit f6145d6 into klaytn:dev Sep 27, 2023
11 checks passed
@blukat29 blukat29 deleted the silence-empty-abook branch October 16, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants