-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Servicechain tx fee hardfork #2018
base: dev
Are you sure you want to change the base?
Conversation
cmd/homi/setup/flags.go
Outdated
@@ -505,4 +505,11 @@ var ( | |||
Usage: "kip103 contract address", | |||
Aliases: []string{"genesis.hardfork.kip103-contract-address"}, | |||
} | |||
|
|||
serviceChainTxFeeCompatibleBlockNumberFlag = &cli.Int64Flag{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed input. The current name appears ambiguous in its purpose. Have you considered renaming it for clarity, perhaps as 'servicechain-consensus-rewardfix'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
I changes hardfork name to ServiceChainRewardFix in a96d57c
However, I will leave this conversation open to hear the opinions of other reviewers
Proposed changes
"serviceChainTxFeeCompatibleBlock":3600
in config),Test Result
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...