New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VM] Use uint256
library for big integer ops
#2024
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsooda
requested review from
blukat29,
2dvorak,
kjeom,
JayChoi1736,
yoomee1313,
sjnam,
ian0371 and
hyeonLewis
as code owners
November 7, 2023 07:04
I'll leave the sync test since it is time-consuming test, instead I'll conduct one more sync test syncing from the latest 100,000 blocks based on this PR for comparison. In addition, I'll update the benchmark test result. Thank you very much. |
yoomee1313
reviewed
Nov 8, 2023
9 tasks
yoomee1313
approved these changes
Nov 9, 2023
sjnam
approved these changes
Nov 9, 2023
blukat29
approved these changes
Nov 9, 2023
hyeonLewis
approved these changes
Nov 9, 2023
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Ported ethereum/go-ethereum#20787
Changes
uint256
libraryEVM
toEVMInterpreter
)The major change is to replace the builtin big integer operations with the
uin256
library.Benchmark-dev
Benchmark-PR
These are some of the key comparisons between PR (above) and dev (bottom). Approximately 4-5x faster.
@yoomee1313, Could you reassess the experiment to determine the computation cost based on these improvements?
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...