New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rectify DB debug APIs chaindbProperty and chaindbCompact #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsooda
requested review from
aidan-kwon,
blukat29,
jeongkyun-oh,
2dvorak,
kjeom and
JayChoi1736
as code owners
December 8, 2023 04:28
blukat29
added
do not merge
don't merge this PR yet
and removed
do not merge
don't merge this PR yet
labels
Dec 8, 2023
blukat29
reviewed
Dec 19, 2023
@blukat29, Removed |
blukat29
previously approved these changes
Dec 20, 2023
PTAL @jeongkyun-oh. We're changing the API you've added. |
blukat29
changed the title
[API] Rectified non-functional legacy LevelDB APIs
Rectify DB debug APIs chaindbProperty and chaindbCompact
Dec 20, 2023
yoomee1313
reviewed
Jan 2, 2024
jeongkyun-oh
previously approved these changes
Jan 9, 2024
@blukat29 The added API |
blukat29
approved these changes
Jan 10, 2024
yoomee1313
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed non-functional legacy LevelDB only APIs (
debug.chaindbProperty
anddebug.chaindbCompact
). I'll appreciate it if you give an idea to refactor the ugly dummy to a succinct style in shardedDB.debug.chaindbProperty(<property>)
debug.chaindbCompact()
manually compacts ldb files.Check out the reduced number of ldb files.
debug.getDBProperty
in favor ofdebug.chaindbProperty
.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...