Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Snapshot delete operation flag added #2064

Merged
merged 3 commits into from Dec 25, 2023

Conversation

hyunsooda
Copy link
Contributor

Proposed changes

This update introduces a dedicated flag, allowing the rewind of a chain specifically triggered by an explicit API call. In the current setHead functionality, deleting the snapshot database around one epoch could be time-consuming (5-10 minutes per epoch on the Cypress network with a 604800 epoch value). The new flag addresses this by selectively deleting the snapshot database only when the call path originates from an explicit API call, not degrading the user experience and potential operator frustration during instantiation.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

blockchain/blockchain.go Outdated Show resolved Hide resolved
@hyunsooda hyunsooda merged commit 3c97580 into klaytn:dev Dec 25, 2023
11 checks passed
@blukat29 blukat29 mentioned this pull request Jan 22, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants