Increase the required go version to 1.20 #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsooda
requested review from
aidan-kwon,
blukat29 and
yoomee1313
as code owners
|
Thank you, @hyunsooda. Do we have to update to 1.20? If it's caused by atomic.Bool, then what about go1.19? |
blukat29
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
@yoomee1313 Because go1.19 is now deprecated, it should be reasonable to require 1.20 or higher. Ref. https://endoflife.date/go "Each major Go release is supported until there are two newer major releases."
blukat29
changed the title
yoomee1313
approved these changes
Dec 21, 2023
aidan-kwon
approved these changes
Dec 28, 2023
|
We can also consider go1.21 including security fixes of |
|
@aidan-kwon Let's update once again when go1.22 is out (along with our CI scripts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
By the change of #2032, the minimal Golang version should be >1.19. (
Atomic.Boolwas introduced in 1.19)Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...