New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: remove computationcost limit at call/estimate apis #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoomee1313
requested review from
sjnam,
ian0371,
hyeonLewis,
blukat29,
hyunsooda,
2dvorak,
kjeom and
JayChoi1736
as code owners
January 5, 2024 08:04
hyunsooda
reviewed
Jan 10, 2024
9 tasks
blukat29
previously approved these changes
Jan 11, 2024
hyunsooda
previously approved these changes
Jan 11, 2024
sjnam
previously approved these changes
Jan 12, 2024
yoomee1313
dismissed stale reviews from sjnam, hyunsooda, and blukat29
via
January 15, 2024 07:17
d8c0f6d
yoomee1313
force-pushed
the
revert-cc-limit
branch
2 times, most recently
from
January 15, 2024 07:49
5be2892
to
c666389
Compare
hyunsooda
previously approved these changes
Jan 16, 2024
hyeonLewis
previously approved these changes
Jan 17, 2024
blukat29
previously approved these changes
Jan 17, 2024
yoomee1313
dismissed stale reviews from blukat29, hyeonLewis, and hyunsooda
via
January 18, 2024 02:27
1772050
yoomee1313
force-pushed
the
revert-cc-limit
branch
from
January 18, 2024 02:28
1772050
to
9067faf
Compare
blukat29
approved these changes
Jan 18, 2024
sjnam
approved these changes
Jan 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Lift computation cost limit at klay_call, klay_estimateGas, klay_estimateComputationCost, eth_call, eth_estimateGas.
No need to use experimental computation cost flag (
--opcode-computation-cost-limit
) as an attempt to bypass the cost limit. The limit is always infinite in such APIs.Computation cost limit after this PR:
params.OpcodeComputationCostLimit
).--opcode-computation-cost-limit
: Use the specified numberTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
klay_estimateComputationCost
#2081reached the opcode computation cost limit
#2083Further comments