-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Show computation costs to StructLog transaction trace #2090
Conversation
`ComputationCost`: CC per opcode
Consider removing the |
@hyunsooda But the |
The calculation is equivalent to accumulating from the limit to each step's opcode CC, and this can be accomplished simply by + sum := cc
for index, trace := range logs {
if logTimeout {
return nil, fmt.Errorf("trace logger timeout")
}
+ sum -= trace.ComputationCost
formatted[index] = StructLogRes{ Initially, I hesitated to implement this change, fearing it might compromise readability. However, I highlighted its value considering the memory-saving benefits, contingent on the number of |
computationCostTotal
and computationCostUsed
Proposed changes
Added two fields,
computationCostTotal
andcomputationCostUsed
indebug.trace*
APIs.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...