VerifyRandao returns proper error when parent state is unavailable #2092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make
VerifyRandao()
return an appropriate error when the parent block state is not found.Currently, the
VerifyRandao()
may return a "missing trie node" error when the parent state is not found. Specifically, the error may be triggered after a rewinding bydebug_setHead
, leading to downloader requests for older blocks lacking the required state. As these blocks undergo verification, they reachVerifyRandao()
, but in full mode node the parent states are not stored, thereby throwing the "missing trie node" error.The parent state is needed to determine the proposer's BLS public key, which is then used to verify the
randomReveal
field.If the parent state is not found,
VerifyHeader()
now returns aconsensus.ErrPrunedAncestor
error so thatBlockChain.InsertChain
can take state regeneration path in https://github.com/klaytn/klaytn/blob/v1.12.0/blockchain/blockchain.go#L1992-L2017.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments