Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istanbul: Fail fast VerifyHeaders, Fix handlerWg #2139

Merged
merged 3 commits into from Apr 30, 2024

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented Apr 24, 2024

Proposed changes

This PR contains three small fixes.

  • Fix VerifyHeaders to fail fast when one of the headers is errored.
    • Consensys/quorum@35f1c3f (#1042)
    • When the VerifyHeaders() and PreprocessHeaderVerification() iterates through a list of consecutive headers, when it encounters a bad header then the rest of them are skipped.
    • Note that in Klaytn VerifyHeaders() is disabled because CanVerifyHeadersConcurrently() is false. So this fix should have no effect.
  • Fix handlerWg location with respect to the standard use case.
  • Remove unused function weightedCouncil.GetValidators()
    • The weightedCouncil.List() does the same job.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@blukat29 blukat29 changed the title istanbul: Fix VerifyHeaders, HandlerWg istanbul: Fail fast VerifyHeaders, Fix handlerWg Apr 24, 2024
@blukat29 blukat29 self-assigned this Apr 24, 2024
hyeonLewis
hyeonLewis previously approved these changes Apr 25, 2024
@blukat29 blukat29 merged commit 43476ee into klaytn:dev Apr 30, 2024
11 checks passed
@blukat29 blukat29 deleted the istanbul-minor-fixes branch April 30, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants