accounts/keystore: Prevent Import race #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blukat29
requested review from
hyunsooda,
2dvorak,
kjeom and
JayChoi1736
as code owners
blukat29
force-pushed
the
keystore-import-mutex
branch
2 times, most recently
from
02e612c
to
7d95568
Compare
blukat29
changed the title
blukat29
changed the title
ian0371
reviewed
Apr 25, 2024
blukat29
force-pushed
the
keystore-import-mutex
branch
from
87118a0
to
0259a34
Compare
Co-authored-by: Chihyun Song <ian0371@gmail.com>
blukat29
force-pushed
the
keystore-import-mutex
branch
from
0259a34
to
543a639
Compare
|
@JayChoi1736 @hyunsooda PTAL |
JayChoi1736
approved these changes
May 3, 2024
ian0371
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
10c214f(#20915)personal_importRawKeyRPC andkcn accounts importcommand.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...