Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Klay -> Kaia in environment variables, protocol #2164

Merged
merged 8 commits into from
May 17, 2024
Merged

Klay -> Kaia in environment variables, protocol #2164

merged 8 commits into from
May 17, 2024

Conversation

ian0371
Copy link
Contributor

@ian0371 ian0371 commented May 14, 2024 •
edited
Loading

Proposed changes

  • Add KAIA_ environment variables.
  • Update remaining KCF/KFF from other PRs.
  • Rename protocol. It can be updated because the name is not used.

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@ian0371 ian0371 self-assigned this May 14, 2024
@ian0371 ian0371 marked this pull request as ready for review May 16, 2024 08:30
hyeonLewis
hyeonLewis reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@hyeonLewis hyeonLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update Klay6x at consensus/protocol.go and Protocol for gxHash, clique?

@ian0371
Copy link
Contributor Author

ian0371 commented May 17, 2024

@hyeonLewis
Variables in node/cn/protocol.go are unused, so I only updated those. I think it's better to just delete them.
It seems variables in consensus/protocol.go are used but only for gxhash and clique which are unused. I think I can update them. Thanks.

@ian0371 ian0371 changed the title Klay -> Kaia in environment variables Klay -> Kaia in environment variables, protocol May 17, 2024
@ian0371 ian0371 requested a review from hyeonLewis May 17, 2024 04:38
@ian0371 ian0371 merged commit 5e92567 into klaytn:dev May 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@2dvorak 2dvorak 2dvorak approved these changes

@hyeonLewis hyeonLewis hyeonLewis approved these changes

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

@jeongkyun-oh jeongkyun-oh Awaiting requested review from jeongkyun-oh jeongkyun-oh is a code owner

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

@kjeom kjeom Awaiting requested review from kjeom kjeom is a code owner

@JayChoi1736 JayChoi1736 Awaiting requested review from JayChoi1736 JayChoi1736 is a code owner

@yoomee1313 yoomee1313 Awaiting requested review from yoomee1313 yoomee1313 is a code owner

@sjnam sjnam Awaiting requested review from sjnam sjnam is a code owner

Assignees

@ian0371 ian0371

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ian0371 @blukat29 @2dvorak @hyeonLewis