Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: Replace CypressCreditV2 at KaiaForkBlockParent #2166

Merged
merged 5 commits into from
May 16, 2024

Conversation

blukat29
Copy link
Contributor

@blukat29 blukat29 commented May 15, 2024

Proposed changes

  • Replace CypressCredit.sol { getPhoto, getNames } with CypressCreditV2.sol { getPhoto, getNames, getEndingPhoto, getEndingNames } at the KaiaForkBlockParent.
  • Update klay_getCypressCredit API to return { photo, names, endingPhoto?, endingNames? }
  • The EndingPhoto and EndingNames to be updated as a separate PR.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

Tested with homi.

homi setup --gen-type local --cn-num 1 --kaia-compatible-blocknumber 60 --cypress --chainID 8217
INFO[05/15,14:51:28 +09] [24|consensus/istanbul/backend/engine.go:575]   Replaced CypressCredit with CypressCreditV2  blockNum=59
> var out = klay.getCypressCredit(); console.log(out.names, '//', out.endingNames, '@', klay.blockNumber);
 Andrew Kim, ..., Zachary Keats //  @ 6
> var out = klay.getCypressCredit(); console.log(out.names, '//', out.endingNames, '@', klay.blockNumber);
 Andrew Kim, ..., Zachary Keats // EndingNames TBU @ 65

hyeonLewis
hyeonLewis previously approved these changes May 16, 2024
@ian0371 ian0371 added the need to merge Need to merge for the next time label May 16, 2024
@ian0371 ian0371 merged commit 2290c96 into klaytn:dev May 16, 2024
11 checks passed
@ian0371 ian0371 deleted the ending-credit branch May 16, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need to merge Need to merge for the next time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants