Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Kaia network names #2184

Merged
merged 5 commits into from
May 24, 2024
Merged

Rename Kaia network names #2184

merged 5 commits into from
May 24, 2024

Conversation

ian0371
Copy link
Contributor

@ian0371 ian0371 commented May 22, 2024

Proposed changes

  • Rename Cypress -> Mainnet, Baobab -> Testnet
  • Provides backward compatibility in flags, configuration files

Types of changes

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@ian0371 ian0371 marked this pull request as ready for review May 24, 2024 05:49
yoomee1313
yoomee1313 reviewed May 24, 2024
View reviewed changes
blockchain/genesis.go Outdated Show resolved Hide resolved
cmd/homi/setup/flags.go Show resolved Hide resolved
blukat29
blukat29 previously approved these changes May 24, 2024
View reviewed changes
@ian0371 ian0371 merged commit d8ab4d1 into klaytn:dev May 24, 2024
11 checks passed
@ian0371 ian0371 mentioned this pull request Jul 3, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blukat29 blukat29 blukat29 approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@JayChoi1736 JayChoi1736 JayChoi1736 approved these changes

@hyeonLewis hyeonLewis Awaiting requested review from hyeonLewis hyeonLewis is a code owner

@sjnam sjnam Awaiting requested review from sjnam sjnam is a code owner

@hyunsooda hyunsooda Awaiting requested review from hyunsooda hyunsooda is a code owner

@2dvorak 2dvorak Awaiting requested review from 2dvorak 2dvorak is a code owner

@kjeom kjeom Awaiting requested review from kjeom kjeom is a code owner

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon aidan-kwon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ian0371 @blukat29 @yoomee1313 @JayChoi1736