Allow the DNS address starting with a number in enode URL parsing logic #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
requested review from
KimKyungup,
kjhman21 and
winnie-byun
as code owners
KimKyungup
previously approved these changes
Apr 9, 2020
KimKyungup
reviewed
Apr 9, 2020
networks/p2p/discover/node.go
Outdated
| } | ||
| if len(host) == 0 { | ||
| return nil, fmt.Errorf("invalid host: host is empty") | ||
| } | ||
|
|
||
| // TODO-Klaytn-Bootnode: Have to solve following issues |
KimKyungup
approved these changes
Apr 9, 2020
winnie-byun
approved these changes
Apr 9, 2020
|
@kjhman21 I am about to merge this PR. If you have any other opinions, please leave the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change is imported from ethereum/go-ethereum@b90cdbaa7 ethereum/go-ethereum@adf007da
About test
The address string with a number was tested on my local machine with
TestParseNode.However, the test case is not updated in this PR since the address can be changed.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)