Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't compute stateDB for non-existing block number #483

Merged
merged 2 commits into from
Apr 10, 2020

Conversation

aidan-kwon
Copy link
Member

@aidan-kwon aidan-kwon commented Apr 9, 2020

Proposed changes

  1. In the changed logic, a break condition of the for loop can cause panic.
    The values of block should not be nil since block.NumberU64() is called in the following logic.

  2. computeStateDB should find the state of the given block. However, it finds the state of the previous block of the given block.

The panic can be triggered when TraceBlock API is called with the block number 1. The API tries to lookup the previous state of the genesis.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

KimKyungup
KimKyungup previously approved these changes Apr 9, 2020
Copy link
Contributor

@KimKyungup KimKyungup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

joowon-byun
joowon-byun previously approved these changes Apr 9, 2020
@aidan-kwon aidan-kwon dismissed stale reviews from joowon-byun and KimKyungup via 855de6a April 9, 2020 08:34
@aidan-kwon
Copy link
Member Author

@kjhman21 I am about to merge this PR. If you have any other opinions, please leave the comments.

@aidan-kwon aidan-kwon merged commit b319855 into klaytn:dev Apr 10, 2020
@aidan-kwon aidan-kwon deleted the 0409-api branch April 10, 2020 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants