Introduce admin_importChainFromString #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**PROBLEM** Previously, admin_importChain() receives the first parameter as a filename. Since it requires file system access, it would be better if we admin_importChain() using string. If we have such a function, we can easily import a block using the RLP-encoded string of the block. **SOLUTION** This PR introduces admin_importChainFromString(). This function receives the first parameter as an RLP-encoded string of a block.
kjhman21
requested review from
aidan-kwon,
KimKyungup and
joowon-byun
as code owners
aidan-kwon
approved these changes
May 19, 2020
joowon-byun
approved these changes
May 20, 2020
KimKyungup
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PROBLEM
Previously, admin_importChain() receives the first parameter as a filename.
Since it requires file system access, it would be better if we
admin_importChain() using string.
If we have such a function, we can easily import a block
using the RLP-encoded string of the block.
SOLUTION
This PR introduces admin_importChainFromString(). This function receives
the first parameter as an RLP-encoded string of a block.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)