Parameterize MaxRequestLength #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joowon-byun
requested review from
ehnuje,
kjhman21,
KimKyungup,
jeongkyun-oh and
aidan-kwon
ehnuje
reviewed
Jun 26, 2020
KimKyungup
reviewed
Jun 26, 2020
aidan-kwon
reviewed
Jun 26, 2020
aidan-kwon
reviewed
Jun 26, 2020
ehnuje
reviewed
Jun 28, 2020
KimKyungup
reviewed
Jun 28, 2020
cmd/utils/flags.go
Outdated
| @@ -500,6 +500,11 @@ var ( | |||
| Usage: "Wait time the rw timer waits for message writing", | |||
| Value: 15 * time.Second, | |||
| } | |||
| MaxRequestContentLengthFlag = cli.IntFlag{ | |||
| Name: "maxRequestContentLength", | |||
| Usage: "Max request content length for http, websocket and gRPC", | |||
There was a problem hiding this comment.
Suggested change
| Usage: "Max request content length for http, websocket and gRPC", | |
| Usage: "Max request content byte length for http, websocket and gRPC", |
There was a problem hiding this comment.
I think "content length" is fine. It will not read content as byte, but string. Indeed, "Content-length" is used as an HTTP header name.
There was a problem hiding this comment.
I changed to content length in byte. What do you think? :)
KimKyungup
reviewed
Jun 29, 2020
KimKyungup
reviewed
Jun 29, 2020
KimKyungup
reviewed
Jun 29, 2020
KimKyungup
reviewed
Jun 29, 2020
KimKyungup
reviewed
Jun 29, 2020
ehnuje
approved these changes
Jun 29, 2020
KimKyungup
approved these changes
Jun 29, 2020
aidan-kwon
reviewed
Jun 29, 2020
| @@ -458,6 +458,20 @@ func (c *Client) newMessage(method string, paramsIn ...interface{}) (*jsonrpcMes | |||
| return &jsonrpcMessage{Version: "2.0", ID: c.nextID(), Method: method, Params: params}, nil | |||
| } | |||
|
|
|||
| func (c *Client) getMessageSize(method string, args ...interface{}) (int, error) { | |||
There was a problem hiding this comment.
Why don't you put this function in `networks/rpc/websocket_test.go"?
There was a problem hiding this comment.
I put in client.go because it could be used at some place less. A new RPC call or a new test code in tests package could be expected.
aidan-kwon
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
Went through an RPC call test in a running node.