Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bad block during sync Baobab #576

Merged
merged 3 commits into from
Jul 28, 2020

Conversation

KimKyungup
Copy link
Contributor

@KimKyungup KimKyungup commented Jul 24, 2020

Proposed changes

Before this PR, bad block can be happened caused by the dereferenced missing trie node in low spec instances.
The missing trie node was dereferenced by the race condition of trieNodeCache reference count.

This PR added GCLock to prevent dereference during commit and reference.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@KimKyungup
Copy link
Contributor Author

I reproduced the issue with https://github.com/KimKyungup/klaytn/tree/badblock_test.
If dereference is executed between commit and reference of state or storage, the issue can be shown,
So this PR prevent dereference during the section.

@KimKyungup
Copy link
Contributor Author

PTAL. @aidan-kwon @jeongkyun-oh @ehnuje @winnie-byun

Copy link
Contributor

@joowon-byun joowon-byun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean 1 0 0 2 2 2 2 1 in your test code? :

// 1	0	0	2	2	2	2	1
testStorage := []byte{100,100,100,200,200,200,200, 100}

Did you tested like : testStorage := []byte{1,-1,0,2,0,0,0,0,-1} locally, or something?

@KimKyungup
Copy link
Contributor Author

What does it mean 1 0 0 2 2 2 2 1 in your test code? :

// 1	0	0	2	2	2	2	1
testStorage := []byte{100,100,100,200,200,200,200, 100}

Did you tested like : testStorage := []byte{1,-1,0,2,0,0,0,0,-1} locally, or something?

It means the test data value to be set in the account's storage.
Ignore the commented value. :)

Copy link
Contributor

@joowon-byun joowon-byun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ehnuje
Copy link
Contributor

ehnuje commented Jul 28, 2020

Will you add a TC for this PR?

@KimKyungup
Copy link
Contributor Author

Will you add a TC for this PR?

No, I won't. :) This test code should change the main code. I think I don't need it.

@KimKyungup
Copy link
Contributor Author

@ehnuje PTAL. :)

@KimKyungup KimKyungup merged commit 05a922b into klaytn:dev Jul 28, 2020
KimKyungup added a commit that referenced this pull request Aug 10, 2020
hotfix : Copied PR(#576) Fix a bad block during sync Baobab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants