-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bad block during sync Baobab #576
Conversation
I reproduced the issue with https://github.com/KimKyungup/klaytn/tree/badblock_test. |
PTAL. @aidan-kwon @jeongkyun-oh @ehnuje @winnie-byun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does it mean 1 0 0 2 2 2 2 1
in your test code? :
// 1 0 0 2 2 2 2 1
testStorage := []byte{100,100,100,200,200,200,200, 100}
Did you tested like : testStorage := []byte{1,-1,0,2,0,0,0,0,-1}
locally, or something?
It means the test data value to be set in the account's storage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Will you add a TC for this PR? |
No, I won't. :) This test code should change the main code. I think I don't need it. |
@ehnuje PTAL. :) |
hotfix : Copied PR(#576) Fix a bad block during sync Baobab
Proposed changes
Before this PR, bad block can be happened caused by the dereferenced missing trie node in low spec instances.
The missing trie node was dereferenced by the race condition of trieNodeCache reference count.
This PR added GCLock to prevent
dereference
duringcommit
andreference
.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...