Implemented KAS repository to load token transfers data #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
requested review from
aidan-kwon,
ehnuje,
KimKyungup,
kjhman21 and
joowon-byun
as code owners
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-tokentransfer
branch
from
a2ce82c
to
8937c30
Compare
KimKyungup
previously approved these changes
Aug 5, 2020
ehnuje
reviewed
Aug 5, 2020
ehnuje
previously approved these changes
Aug 5, 2020
aidan-kwon
reviewed
Aug 6, 2020
| } | ||
|
|
||
| // transformsLogsToTokenTransfers converts the given event into Klaytn Compatible Token transfers. | ||
| func transformsLogsToTokenTransfers(event blockchain.ChainEvent) []*KCTTransfer { |
There was a problem hiding this comment.
How about changing transformsLogsToTokenTransfers to transformLogsToTokenTransfers or transformEventToTokenTransfers?
There was a problem hiding this comment.
This looks confusing.. 😅
It is hard to distinguish between transformsLogsToTokenTransfers and transformLogToTokenTransfer.
There was a problem hiding this comment.
Removed s! 5a41a8a
aidan-kwon
reviewed
Aug 6, 2020
aidan-kwon
previously approved these changes
Aug 6, 2020
jeongkyun-oh
force-pushed
the
PDK-1561-repository-impl-tokentransfer
branch
from
5a41a8a
to
e778d68
Compare
KimKyungup
approved these changes
Aug 6, 2020
ehnuje
approved these changes
Aug 6, 2020
aidan-kwon
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...