complete KAS anchor feature (NEED TO REBASE THE LAST PR) #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKyungup
requested review from
aidan-kwon,
ehnuje,
jeongkyun-oh,
kjhman21 and
joowon-byun
as code owners
KimKyungup
force-pushed
the
anchor_5_complete
branch
from
fafc1cd
to
d831362
Compare
|
I will rebase this on the last PR. |
ehnuje
reviewed
Aug 10, 2020
cmd/utils/nodecmd/dumpconfigcmd.go
Outdated
| @@ -287,6 +287,10 @@ func makeServiceChainConfig(ctx *cli.Context) (config sc.SCConfig) { | |||
| cfg.KASAnchor = ctx.GlobalBool(utils.KASServiceChainAnchorFlag.Name) | |||
| if cfg.KASAnchor { | |||
| cfg.KASAnchorPeriod = ctx.GlobalUint64(utils.KASServiceChainAnchorPeriodFlag.Name) | |||
| if cfg.KASAnchorPeriod == 0 { | |||
| cfg.KASAnchorPeriod = 1 | |||
| logger.Warn("KAS anchor period is set by 1") | |||
There was a problem hiding this comment.
Suggested change
| logger.Warn("KAS anchor period is set by 1") | |
| logger.Warn("KAS anchor period is not given, KAS anchor period is set by 1") |
There was a problem hiding this comment.
This case is that user gives 0 for this option. :)
There was a problem hiding this comment.
Then the message should be something like below to notify the user that the anchor period can't be set as 0.
As KAS anchor period can't be set as 0, now KAS anchoring started with the period as 1
console/web3ext/web3ext.go
Outdated
| @@ -1012,6 +1012,11 @@ web3._extend({ | |||
| call: 'subbridge_unsubscribeBridge', | |||
| params: 2 | |||
| }), | |||
| new web3._extend.Method({ | |||
| name: 'KASAnchor', | |||
| call: 'subbridge_kASAnchor', | |||
There was a problem hiding this comment.
Suggested change
| call: 'subbridge_kASAnchor', | |
| call: 'subbridge_kasAnchor', |
There was a problem hiding this comment.
subbridge_kASAnchor looks werid. But this is for subbridge.KASAnchor(). :)
@KimKyungup Could you please check this comment? |
KimKyungup
force-pushed
the
anchor_5_complete
branch
from
d831362
to
2eb90d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR is the last PR of KAS anchor feature.
Below works are included.
KASAnchorAPIKASAnchoirPeriodTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...