Add a cmd flag to allow locally submitted anchor transactions #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKyungup
requested review from
aidan-kwon,
ehnuje,
jeongkyun-oh,
kjhman21 and
joowon-byun
as code owners
aidan-kwon
reviewed
Aug 12, 2020
Co-authored-by: Donghwan Aidan Kwon <48199072+aidan-kwon@users.noreply.github.com>
aidan-kwon
previously approved these changes
Aug 12, 2020
ehnuje
reviewed
Aug 13, 2020
cmd/utils/flags.go
Outdated
| @@ -133,6 +133,10 @@ var ( | |||
| Name: "txpool.nolocals", | |||
| Usage: "Disables price exemptions for locally submitted transactions", | |||
| } | |||
| TxPoolAllowLocalAnchorTxFlag = cli.BoolFlag{ | |||
| Name: "txpool.allowlocalanchortx", | |||
There was a problem hiding this comment.
txpool.allowlocalanchortx looks confusing.. how about txpool.allow-local-anchortx?
There was a problem hiding this comment.
Good. I will reflect.
KimKyungup
commented
Aug 13, 2020
ehnuje
reviewed
Aug 13, 2020
blockchain/tx_pool.go
Outdated
| @@ -54,6 +55,8 @@ var ( | |||
| statsReportInterval = 8 * time.Second // Time interval to report transaction pool stats | |||
|
|
|||
| txPoolIsFullErr = fmt.Errorf("txpool is full") | |||
|
|
|||
| errNotAllowedTx = errors.New("not allowed tx") | |||
There was a problem hiding this comment.
Suggested change
| errNotAllowedTx = errors.New("not allowed tx") | |
| errNotAllowedTx = errors.New("locally anchoring chaindata tx is not allowed in this node") |
There was a problem hiding this comment.
@ehnuje I intended not to write the transaction type on this error for using commonly.
Instead of that, I added the tx type when the error is returned.
Please check 955 line.
aidan-kwon
previously approved these changes
Aug 13, 2020
ehnuje
approved these changes
Aug 13, 2020
aidan-kwon
approved these changes
Aug 13, 2020
OK I will. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR added
allowlocalanchortxcmd flag makes txpool to allow locally submitted anchor transctions.For public endpoint node, it is necessary to prevent anchor transactions. So this option is added.
This PR reverted the feature is removed in #572.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...