Parameterize Dynamodb config #615
Conversation
joowon-byun
requested review from
ehnuje,
kjhman21,
jeongkyun-oh and
aidan-kwon
| @@ -67,6 +67,11 @@ Make sure you backup your keys regularly.`, | |||
| utils.SingleDBFlag, | |||
There was a problem hiding this comment.
Is it necessary theses options related with DB for accountcmd?
@winnie-byun Please check the history and if not please remove all.
| @@ -40,8 +41,11 @@ var ( | |||
| Name: "attach", | |||
| Usage: "Start an interactive JavaScript environment (connect to node)", | |||
| ArgsUsage: "[endpoint]", | |||
| Flags: append(ConsoleFlags, utils.DbTypeFlag, utils.SingleDBFlag, utils.NumStateTrieShardsFlag, utils.LevelDBCompressionTypeFlag, utils.DataDirFlag), | |||
| Category: "CONSOLE COMMANDS", | |||
| Flags: append(ConsoleFlags, utils.SingleDBFlag, utils.DataDirFlag, utils.NumStateTrieShardsFlag, | |||
There was a problem hiding this comment.
Is it necessary theses options related with DB for consolecmd?
@winnie-byun Please check the history and if not please remove all.
| @@ -214,7 +214,7 @@ var ( | |||
| } | |||
| DynamoDBTableNameFlag = cli.StringFlag{ | |||
| Name: "db.dynamo.tablename", | |||
There was a problem hiding this comment.
Don't we need to change db.dynamo to db.dynamos3?
There was a problem hiding this comment.
If a user wants to use dynamoDB, one needs to set --dbtype DynamoDBS3. I thought this change will alert users that both dynamoDB and S3 will be created.
Do you think changing db.dynamo to db.dynamos3 is necessary in all codes?
There was a problem hiding this comment.
Though this is not that necessarily, I think this can confuse users because if you want to use dynamodb, you need to user the word "dynamos3". However, to set up configuration, what used is "dynamo". I think it's up to you 😅
Proposed changes
Able to set parameter for dynamo DB.
--db.dynamo.tablename--db.dynamo.region--db.dynamo.is-provisioned--db.dynamo.read-capacity--db.dynamo.write-capacityTypes of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments