Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamo use gloabal worker #624
Dynamo use gloabal worker #624
Changes from all commits
29584aa
8b4da94
76589ae
b740ac8
6166751
9fbc435
5a8b175
5257c02
8edc22c
c79e5e9
5df4f49
475de17
be3c47c
b15e8af
86a8f63
da0f741
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any possibility of panic if
Close
is called while processingPut
operation?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just tested.
A panic will not occur even though
Close()
is called on non-empty channel. (callPut()
->Close()
) It will close after all of the items are processed.However, a panic will occur when put is called in a closed channel (call
Close()
->Put()
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. To avoid the second case, we need to use switch & case. Do you have any other alternatives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we use the original code, not all of the items in the channel will be processed. There might be some items we expect to be writen but actually no. Actually, in the original code, it will wait inifinitively in
Write()
because the workers will not process the input andwg.Done()
is not called.Is there other ways to handle both cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to consider the 2nd case. It is misbehavior of users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the case which rarely happens.
However, I don't think it is misbehavior of users. Since the user does not know whether it will cause panic or not.
However, again, as
Database.Close
is called afterBlockchain.Stop
, there is no possibility thatDatabase.Put
is called afterDatabase.Close
.