[Debug] DynamoDB #633
[Debug] DynamoDB #633
Conversation
joowon-byun
requested review from
ehnuje,
KimKyungup,
jeongkyun-oh and
aidan-kwon
| @@ -406,6 +409,10 @@ func createBatchWriteWorker(writeCh <-chan *batchWriteWorkerInput) { | |||
| numUnprocessed := len(BatchWriteItemOutput.UnprocessedItems[batchInput.tableName]) | |||
| for err != nil || numUnprocessed != 0 { | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "ValidationException") { | |||
There was a problem hiding this comment.
Why does this error happen?
- If we remove the dynamoDB table, it can be happen?
There was a problem hiding this comment.
It happens when there is a input errror such as duplicated input in batch, 0 or more than 25 items in batch, empty input in item and so on.
When we remove teh dynamoDB table, ResourceNotFoundException will occur. But this error can also occur when the table is being created or archived. I don't think it is a good idea to crit on ResourceNotFoundException because it can be solved when time passes.
There was a problem hiding this comment.
What is duplicated input? Is it same key/value item with another one?
There was a problem hiding this comment.
Yes, if there are two items with the same key, it is an error.
There was a problem hiding this comment.
OK. I got it your intention.
Please write some comments about the case of the error and why this crit is needed.
Proposed changes
klaytn-default-misc(always had-miscpostfix) ->klaytn-defaultklaytn-default->klaytn-default-misc,klaytn-default-header, ...Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments