cmd, blockchain: added overwrite-genesis flag #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehnuje
requested review from
aidan-kwon,
jeongkyun-oh,
KimKyungup,
kjhman21,
joowon-byun and
yoomee1313
as code owners
This comment has been minimized.
This comment has been minimized.
|
Dear reviewers, could you please review this change? |
aidan-kwon
reviewed
Sep 1, 2020
blockchain/genesis.go
Outdated
| } | ||
| logger.Warn("found previous block", "blockNum", headBlock.NumberU64()) | ||
| } | ||
| logger.Warn("found the latest block with state", |
There was a problem hiding this comment.
This log could be set to Info level.
jeongkyun-oh
reviewed
Sep 1, 2020
jeongkyun-oh
previously approved these changes
Sep 1, 2020
aidan-kwon
approved these changes
Sep 1, 2020
jeongkyun-oh
approved these changes
Sep 1, 2020
KimKyungup
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
--overwrite-genesisto overwrite pre-existing genesis block to run a test with Baobab or Cypress chaindata.initcommand with--overwrite-genesisflag, it will overwrites the data from new genesis.json over previous state data.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...