Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Publish/Subscribe method of redis cache #676

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

aidan-kwon
Copy link
Member

Proposed changes

If a redis client publishes a message to a channel, other clients subscribing the channel at the publishing time receives the message.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@KimKyungup
Copy link
Contributor

Thanks. @aidan-kwon :)

Copy link
Contributor

@joowon-byun joowon-byun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just a few questions :)

storage/statedb/cache_redis_test.go Show resolved Hide resolved
storage/statedb/cache_redis.go Show resolved Hide resolved
@KimKyungup KimKyungup removed the draft label Sep 21, 2020
@aidan-kwon aidan-kwon merged commit 081f2f2 into klaytn:dev Sep 21, 2020
@aidan-kwon aidan-kwon deleted the redisSubscription branch September 21, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants