Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: ReadCachedTrieNode leaves a log for the unexpected cases #683

Merged
merged 4 commits into from
Sep 24, 2020

Conversation

ehnuje
Copy link
Contributor

@ehnuje ehnuje commented Sep 23, 2020

Proposed changes

  • When ReadCachedTrieNode receives an error except for dataNotFoundErr, it leaves an error log
  • This is to check the unexpected error cases.
  • Now, every Klaytn database returns nil, dataNotFoundErr for val, err when it fails to find the data

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ehnuje
Copy link
Contributor Author

ehnuje commented Sep 24, 2020

@jeongkyun-oh @yoomee1313 @winnie-byun Please take a look =)

@ehnuje ehnuje merged commit 6c5b89c into klaytn:dev Sep 24, 2020
@ehnuje ehnuje deleted the 0923-error-log-for-read-cached-node branch September 24, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants