New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implmeneted data split for kafka message #708
Conversation
Could you please add some comments in TestKafka_split and TestKafka_makeProducerMessage function? It would be easier to understand the tests with more comments! |
Alright. I will add some comments. e9e1d2a |
I have some questions and comments.
|
7672dfa
to
e533714
Compare
e533714
to
e9e1d2a
Compare
@winnie-byun Thanks for your comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the kind explaination. I didn't see makeProducerMessage
before.
This code looks good to be :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except minor comments
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)