Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused cache(cachedStateObjects) and related configs #730

Merged
merged 9 commits into from
Oct 29, 2020

Conversation

joowon-byun
Copy link
Contributor

@joowon-byun joowon-byun commented Oct 27, 2020

Proposed changes

The belows are removed from Klaytn:

  • [f78493a]stateDB.cachedStateObjects: not used in default and Database.trieNodeCache, or Fastcache, is used instead

  • [8e26811] StateDBCachingFlag: was used to set stateDB.cachedStateObjects

  • [4190c91] Blockchain.cachedStateDB : was used to store the current cache cachedStateObjects from last block. But, the data is stored in Fastcache, too.

  • [0fffbad] Blockchain.lastUpdatedRootHash : was used to check if the current hash is stored in Blockchain.cachedStateDB

  • [d14e0da]cacheGetStateDBMissMeter: was to measure cache miss of Blockchain.lastUpdatedRootHash

  • [99b4a68] [c195de3] TryGetCachedStateDB and StateAtWithCache: are used to call StateDB with cachedStateObjects. Now, TryGetCachedStateDB is replaced with StateAt.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

Copy link
Contributor

@ehnuje ehnuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@aidan-kwon aidan-kwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joowon-byun joowon-byun merged commit f307c04 into klaytn:dev Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants