Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write governance items during init process #733

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

aidan-kwon
Copy link
Member

Proposed changes

Currently, governance items of the genesis block are stored when the node started.
This change makes the items to be stored during the init process.
Also, some governance-related code is refactored.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

ehnuje
ehnuje previously approved these changes Oct 30, 2020
yoomee1313
yoomee1313 previously approved these changes Oct 30, 2020
governance/default.go Outdated Show resolved Hide resolved
Co-authored-by: Ethan (Kyungup Kim) <ethan.kim@groundx.xyz>
@aidan-kwon aidan-kwon dismissed stale reviews from yoomee1313 and ehnuje via 32275bf October 30, 2020 04:52
@aidan-kwon aidan-kwon merged commit 627289f into klaytn:dev Nov 2, 2020
@aidan-kwon aidan-kwon deleted the 201030-initGovItem branch November 2, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants