-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracers: fix err in 4byte, add unigram/bigram/trigram opcode analysis… #752
Conversation
205ac8b
to
9059a56
Compare
@yoomee1313 Please check and show the result of new tracers. |
7f9b0f0
to
98a1ae1
Compare
@KlaytnDev I added the results of new tracers. Also, I changed descriptions of tracers in this commit (98a1ae1). |
98a1ae1
to
8a8c113
Compare
@yoomee1313 @KimKyungup Will this new tracers be introduced in Klaytn Docs, right? 😄 |
@kjhman21 Yes, updating Klaytn Docs(https://docs.klaytn.com/bapp/json-rpc/api-references/debug/tracing#debug_tracetransaction) is necessary when those new tracers are included in release |
@yoomee1313 Not to miss updating the docs, how about making a JIRA item to track the task? |
@ehnuje Instead of making a JIRA item, i will tag a label to the PRs that need docs! |
@yoomee1313 Please update klaytn-docs before merging this. |
Proposed changes
This PR is derived from ethereum/go-ethereum#16954.
4byteTracer
.unigram_tracer.js
which just counts opcodes.bigram_tracer.js
which counts bigrams.trigram_tracer.js
which counts trigrams.New Tracers Output
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...