Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracers: fix err in 4byte, add unigram/bigram/trigram opcode analysis… #752

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

yoomee1313
Copy link
Contributor

@yoomee1313 yoomee1313 commented Nov 18, 2020

Proposed changes

This PR is derived from ethereum/go-ethereum#16954.

  • It fixes an error in the 4byteTracer.
  • It adds unigram_tracer.js which just counts opcodes.
  • It adds bigram_tracer.js which counts bigrams.
  • It adds trigram_tracer.js which counts trigrams.

New Tracers Output

  • unigram_tracer.js
    image
  • bigram_tracer.js
    image
  • trigram_tracer.js
    image

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@KimKyungup
Copy link
Contributor

@yoomee1313 Please check and show the result of new tracers.

@yoomee1313
Copy link
Contributor Author

@KlaytnDev I added the results of new tracers. Also, I changed descriptions of tracers in this commit (98a1ae1).

ehnuje
ehnuje previously approved these changes Nov 19, 2020
ehnuje
ehnuje previously approved these changes Nov 19, 2020
@kjhman21
Copy link
Collaborator

@yoomee1313 @KimKyungup Will this new tracers be introduced in Klaytn Docs, right? 😄

@yoomee1313
Copy link
Contributor Author

@kjhman21 Yes, updating Klaytn Docs(https://docs.klaytn.com/bapp/json-rpc/api-references/debug/tracing#debug_tracetransaction) is necessary when those new tracers are included in release

@ehnuje
Copy link
Contributor

ehnuje commented Nov 20, 2020

@kjhman21 Yes, updating Klaytn Docs(https://docs.klaytn.com/bapp/json-rpc/api-references/debug/tracing#debug_tracetransaction) is necessary when those new tracers are included in release

@yoomee1313 Not to miss updating the docs, how about making a JIRA item to track the task?

@yoomee1313
Copy link
Contributor Author

@kjhman21 Yes, updating Klaytn Docs(https://docs.klaytn.com/bapp/json-rpc/api-references/debug/tracing#debug_tracetransaction) is necessary when those new tracers are included in release

@yoomee1313 Not to miss updating the docs, how about making a JIRA item to track the task?

@ehnuje Instead of making a JIRA item, i will tag a label to the PRs that need docs!

@KimKyungup
Copy link
Contributor

@yoomee1313 Please update klaytn-docs before merging this.

@yoomee1313 yoomee1313 merged commit 2074eb0 into klaytn:dev Nov 23, 2020
@yoomee1313 yoomee1313 deleted the tracers-16954 branch November 23, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants