Changed metrics.Meter to metrics.Timer #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehnuje
requested review from
aidan-kwon,
jeongkyun-oh and
joowon-byun
as code owners
aidan-kwon
previously approved these changes
Dec 11, 2020
KimKyungup
previously approved these changes
Dec 11, 2020
jeongkyun-oh
previously approved these changes
Dec 11, 2020
ehnuje
dismissed stale reviews from jeongkyun-oh, KimKyungup, and aidan-kwon
via
406442f
ehnuje
force-pushed
the
1211-meter-to-timer
branch
from
ebc8de2
to
406442f
Compare
|
I found that |
KimKyungup
previously approved these changes
Dec 11, 2020
aidan-kwon
previously approved these changes
Dec 11, 2020
jeongkyun-oh
previously approved these changes
Dec 11, 2020
|
@winnie-byun Could you please take a look? |
joowon-byun
previously approved these changes
Dec 11, 2020
joowon-byun
reviewed
Dec 11, 2020
Co-authored-by: Winnie (Joowon) <joowon7508@gmail.com>
ehnuje
dismissed stale reviews from jeongkyun-oh, aidan-kwon, and KimKyungup
via
2fb15b9
ehnuje
requested review from
joowon-byun,
jeongkyun-oh,
aidan-kwon and
KimKyungup
joowon-byun
approved these changes
Dec 11, 2020
aidan-kwon
approved these changes
Dec 11, 2020
KimKyungup
approved these changes
Dec 11, 2020
jeongkyun-oh
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
metrics.Metermight be distorted by the rate of data entered, changemetrics.Metertometrics.Timer, which is designed to collect duration metrics.Timer.Mean()is exported with the original metric name and0.5, 0.75, 0.95, 0.99, 0.999, 0.9999percentile metrics are also exported with the suffixes "_0_5", "_0_75", "_0_95", "_0_99", "_0_999", "_0_9999"Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...