params, blockchain/vm: rename hardfork name, Incompatible1 to IstanbulCompatible #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lCompatible * renamed hardfork name -> IstanbulCompatible * renamed PrecompiledContractsCypress -> PrecompiledContractsConstantinople * indicate TODO-IstanbulCompatible * introduce PrecompiledContractsIstanbul * introduce IstanbulInstructionSet
yoomee1313
requested review from
aidan-kwon,
ehnuje,
jeongkyun-oh,
KimKyungup and
joowon-byun
as code owners
KimKyungup
reviewed
Feb 22, 2021
KimKyungup
reviewed
Feb 22, 2021
KimKyungup
previously approved these changes
Feb 22, 2021
aidan-kwon
reviewed
Feb 24, 2021
aidan-kwon
previously approved these changes
Feb 24, 2021
KimKyungup
reviewed
Feb 24, 2021
yoomee1313
dismissed stale reviews from aidan-kwon and KimKyungup
via
080ecca
yoomee1313
force-pushed
the
rename-incompatibleChange1-to-istanbulCompatible
branch
from
080ecca
to
286be20
Compare
ehnuje
reviewed
Feb 25, 2021
ehnuje
reviewed
Feb 25, 2021
This comment has been minimized.
This comment has been minimized.
yoomee1313
force-pushed
the
rename-incompatibleChange1-to-istanbulCompatible
branch
from
8919a38
to
5da9f9c
Compare
aidan-kwon
previously approved these changes
Feb 26, 2021
|
@KimKyungup @ehnuje There was a linter problem, so i fixed it. Please take a look. |
KimKyungup
previously approved these changes
Mar 2, 2021
|
@yoomee1313 Could you please check the conflicts? |
ehnuje
approved these changes
Mar 2, 2021
|
@ehnuje @KimKyungup I changed address of precompiled address of vmLog, feePayer, and validateSender. Conflict came out, so i resolved it. |
aidan-kwon
approved these changes
Mar 2, 2021
KimKyungup
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...