Added Staking Information API #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
requested review from
aidan-kwon,
KimKyungup and
yoomee1313
as code owners
yoomee1313
reviewed
Mar 25, 2021
KimKyungup
reviewed
Mar 26, 2021
Comment on lines
+169
to
+177
| blockNumber := uint64(0) | ||
| if num == nil || *num == rpc.LatestBlockNumber { | ||
| blockNumber = api.governance.blockChain.CurrentHeader().Number.Uint64() | ||
| } else if *num == rpc.PendingBlockNumber { | ||
| return nil, kerrors.ErrPendingBlockNotSupported | ||
| } else { | ||
| blockNumber = uint64(num.Int64()) | ||
| } | ||
| return reward.GetStakingInfo(blockNumber), nil |
There was a problem hiding this comment.
There are many repeated code. I think it can be defined as a function.
There was a problem hiding this comment.
Right. This is not only repeated one. Can we update this later with other repeated code fragments?
|
@aidan-kwon @yoomee1313 Please take a look. |
yoomee1313
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
BlockNumis the block where staking information of Council is fetched.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)