Updated istanbul consensus engine to verify headers synchronously #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
requested review from
aidan-kwon,
ehnuje,
KimKyungup,
joowon-byun and
yoomee1313
as code owners
ehnuje
reviewed
May 7, 2021
aidan-kwon
reviewed
May 7, 2021
jeongkyun-oh
force-pushed
the
KLT-754-sync-verify-header
branch
2 times, most recently
from
7912509
to
010bf47
Compare
aidan-kwon
reviewed
May 7, 2021
aidan-kwon
reviewed
May 7, 2021
KimKyungup
reviewed
May 8, 2021
KimKyungup
reviewed
May 8, 2021
KimKyungup
reviewed
May 8, 2021
jeongkyun-oh
force-pushed
the
KLT-754-sync-verify-header
branch
from
30c1951
to
a72a027
Compare
KimKyungup
reviewed
May 11, 2021
KimKyungup
approved these changes
May 11, 2021
|
@ehnuje @winnie-byun @yoomee1313 Please take a look. |
joowon-byun
approved these changes
May 12, 2021
ehnuje
approved these changes
May 14, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
UPDATE: The addresses cache is updated. Previously, the
ecrecovermethod used an ARU cache with block hash as a key, but we need to cache all the addresses recovered from committed seals of a block. So, 65-bytes signatures are used as keys. Furthermore, the size of the cache is increased to 2048 * 30 (max number of downloaded blocks * approximate sub group size of validators).After the PR Updated minimum staking related logic #920, the
Refreshmethod must be called all the time to refresh proposer candidates as well as validators.The
Refreshmethod wasn't always called before because the header verification concurrently occurs while downloading a batch of blocks. (If the header does not exist, it ignores to refresh)The
Refreshmethod didn't work properly since it was failed to get staking information to verify headers. (It tries to call a contract method on a specific block which is not yet inserted)This PR updates the header verification synchronously, while the computation of addresses will be processed concurrently to prevent download performance.
The simple synchronous verification performs poorly as below panel, so extracting the pub key from seals handled concurrently.
The comparision sync test is attached.
EN0 : master branch (Klaytn v1.6.1+f695312c38)
EN1 : After this PR (Klaytn v1.6.1+d76876935e)
EN2 : Before this PR (Klaytn v1.6.1+37b05fe791)
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)