Modified to use senderCache when prefetching with Lock unlike #962 #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKyungup
requested review from
aidan-kwon,
ehnuje and
joowon-byun
as code owners
KimKyungup
force-pushed
the
prefetch_cpu_usage_issue_with_lock
branch
from
440bd53
to
56f1063
Compare
ehnuje
previously approved these changes
May 14, 2021
9 tasks
|
PTAL. :) |
|
Could you explain specifically how this modification solves the problem? |
I added this lock to prohibit a race condition between below logics. But After your comment, I figure out that the blocknumber can make a race condition with different blocknumber. |
joowon-byun
approved these changes
May 17, 2021
|
PTAL. :) |
ehnuje
approved these changes
May 18, 2021
jeongkyun-oh
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Like #962, this PR can resolve the issue. But the added
lockcan protects a race condition of the uint64 variable.Test Result
EN0 : v1.6.1
EN1 : v1.6.2.rc3
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...