Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling in NewTrieForPrefetching #969

Merged
merged 1 commit into from
May 17, 2021

Conversation

joowon-byun
Copy link
Contributor

@joowon-byun joowon-byun commented May 17, 2021

Proposed changes

  • This PR adds error handling in NewTrieForPrefetching.
  • Previously, if NewTrie returns error, trie is returned with nil.
    This eventually made nil pointer dereference error in trie.prefetching = true

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@joowon-byun joowon-byun self-assigned this May 17, 2021
@joowon-byun joowon-byun changed the title handle err Add error handling in NewTrieForPrefetching May 17, 2021
@KimKyungup KimKyungup merged commit ad9e8c1 into klaytn:dev May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants