api: Add http api and deprecate rpc api #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan-brown
requested review from
KimKyungup,
jeongkyun-oh,
aidan-kwon and
yoomee1313
ehnuje
reviewed
May 18, 2021
Co-authored-by: Melvin Junhee Woo <melvin.woo@groundx.xyz>
yoomee1313
reviewed
May 18, 2021
This comment has been minimized.
This comment has been minimized.
ehnuje
approved these changes
May 21, 2021
yoomee1313
approved these changes
May 21, 2021
jeongkyun-oh
approved these changes
May 21, 2021
KimKyungup
approved these changes
May 21, 2021
aidan-kwon
approved these changes
May 24, 2021
hyochan-brown
deleted the
feature/KLT-833-add-http-api-and-deprecate-rpc-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
To enhance compatibility with Ethereum.
It feels awkward to have an api in the utils.go. It is also not compatible with Ethereum.
I wrote it by referring to the test code of Ethereum.
The referenced Ethereum PR
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)Related issues
Further comments
Please let me know if there is anything lacking in PR or code.