-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent nil receipts and added retry logic for making chain events #977
Closed
jeongkyun-oh
wants to merge
6
commits into
klaytn:dev
from
jeongkyun-oh:KLT-861-update-make-chain-event
Closed
Prevent nil receipts and added retry logic for making chain events #977
jeongkyun-oh
wants to merge
6
commits into
klaytn:dev
from
jeongkyun-oh:KLT-861-update-make-chain-event
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongkyun-oh
requested review from
aidan-kwon,
ehnuje,
hyochan-brown,
KimKyungup and
yoomee1313
as code owners
May 26, 2021 04:37
jeongkyun-oh
changed the title
Klt 861 update make chain event
Prevent nil receipts and added retry logic for making chain events
May 26, 2021
jeongkyun-oh
force-pushed
the
KLT-861-update-make-chain-event
branch
from
May 26, 2021 05:24
0844044
to
da94fd1
Compare
hyochan-brown
previously approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
I have only one question.
aidan-kwon
previously approved these changes
May 27, 2021
ehnuje
previously approved these changes
May 27, 2021
joowon-byun
reviewed
May 27, 2021
jeongkyun-oh
force-pushed
the
KLT-861-update-make-chain-event
branch
from
May 27, 2021 11:55
c8c6f32
to
4aa6d4f
Compare
aidan-kwon
previously approved these changes
May 28, 2021
ehnuje
previously approved these changes
May 28, 2021
jeongkyun-oh
force-pushed
the
KLT-861-update-make-chain-event
branch
from
May 28, 2021 06:00
42dbd42
to
d13cb3a
Compare
jeongkyun-oh
force-pushed
the
KLT-861-update-make-chain-event
branch
from
May 28, 2021 06:36
d13cb3a
to
794d477
Compare
joowon-byun
reviewed
May 28, 2021
joowon-byun
approved these changes
May 28, 2021
@jeongkyun-oh What is the root cause of not having a receipt? |
@KimKyungup Unexpected errors occur in DynamoDB unlike LevelDB. The retry logic is added for unexpected temporary errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Making a chain event is done locally after getting items from database. It was hard to get an error, but the error case is not handled properly. This change checks if receipt list is nil or not, and added retrying logic for making chain events.
Unlike retrying to produce Kafka messages, it should not fail to get data from the database. It retries inifinately, but after 100 retry it leaves error logs.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)